martin/POPS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix UnboundLocalError for filament_low in start_job

Browse Source 
Variable was only assigned inside a nested if-block; initialise to False
at the top of the filament-logging section so all code paths define it.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Martin Hohenberg
2026-06-19 08:00:16 +02:00
parent 5dfa700916
commit 726a4d3c02
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/routers/ui.py
View File

@@ -345,6 +345,7 @@ def start_job(job_id: int, printer_id: int = Form(...), db: Session = Depends(ge
db.add(JobLog(job_id=job_id, message=f"Job started on {printer.name}")) db.add(JobLog(job_id=job_id, message=f"Job started on {printer.name}"))
# Log filament usage against matching AMS roll in FilamentDB # Log filament usage against matching AMS roll in FilamentDB
filament_low = False
if job.job_material and job.job_color: if job.job_material and job.job_color:
stl = db.query(StlCache).filter_by(filename=job.file_name).first() if job.file_name else None stl = db.query(StlCache).filter_by(filename=job.file_name).first() if job.file_name else None
if stl and stl.volume_ccm: if stl and stl.volume_ccm:
@@ -353,7 +354,6 @@ def start_job(job_id: int, printer_id: int = Form(...), db: Session = Depends(ge
if roll: if roll:
note = (f"POPS {job.job_uuid[:8] if job.job_uuid else job.id}: " note = (f"POPS {job.job_uuid[:8] if job.job_uuid else job.id}: "
f"{job.file_name or job.name} on {printer.name}") f"{job.file_name or job.name} on {printer.name}")
filament_low = False
if log_print_on_roll(roll["roll_id"], weight_g, note): if log_print_on_roll(roll["roll_id"], weight_g, note):
db.add(JobLog(job_id=job_id, message=( db.add(JobLog(job_id=job_id, message=(
f"FilamentDB: logged {weight_g} g against roll #{roll['roll_id']} " f"FilamentDB: logged {weight_g} g against roll #{roll['roll_id']} "